Re: [RESEND PATCH 2/2] arm64: dts: rockchip: add Coresight debug range for RK3399
From: Doug Anderson <dianders@chromium.org>
Date: 2021-09-08 15:10:01
Also in:
linux-clk, linux-rockchip, lkml
Hi, On Tue, Sep 7, 2021 at 9:46 AM Brian Norris [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Per Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt. This IP block can be used for sampling the PC of any given CPU, which is useful in certain panic scenarios where you can't get the CPU to stop cleanly (e.g., hard lockup). Signed-off-by: Brian Norris <briannorris@chromium.org> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 48 ++++++++++++++++++++++++ 1 file changed, 48 insertions(+)diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 3871c7fd83b0..c8c62637b600 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi@@ -433,6 +433,54 @@ usbdrd_dwc3_1: usb@fe900000 { }; }; + debug@fe430000 {
I think your sort order is wrong? 0xfe430000 comes before 0xfe900000? Other than that this looks good to me. Reviewed-by: Douglas Anderson <dianders@chromium.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel