Re: [PATCH 1/3] arm64: dts: ti: iot2050: Flip mmc device ordering on Advanced devices
From: Jan Kiszka <jan.kiszka@siemens.com>
Date: 2021-09-07 15:30:26
Also in:
linux-devicetree, lkml
On 07.09.21 17:27, Nishanth Menon wrote:
On 17:20-20210907, Jan Kiszka wrote:quoted
On 07.09.21 17:13, Nishanth Menon wrote:quoted
On 16:22-20210907, Jan Kiszka wrote:quoted
From: Jan Kiszka <jan.kiszka@siemens.com> This ensures that the SD card will remain mmc0 across Basic and Advanced devices, also avoiding surprises for users coming from the downstream kernels. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts index ec9617c13cdb..d1d5278e0b94 100644 --- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts +++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts@@ -18,6 +18,11 @@ / { compatible = "siemens,iot2050-advanced", "ti,am654"; model = "SIMATIC IOT2050 Advanced"; + aliases { + mmc0 = &sdhci1; + mmc1 = &sdhci0; + };Should we do this at SoC level?Well, I wouldn't mind - but that would also impact your EVMs. For us, this is fine as we are coming from that ordering above with our downstream kernel/dts.I think it'd probably be a welcome change. overall we've standardized on partuuid.
Yeah, it's more about "dd if=emmc.img of=/dev/mmcblk1 - damn, the wrong one again." Let me know what you prefer, and I'll update my patch. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel