Re: [PATCH v7 3/5] dt-binding: mt8183: Add Mediatek MDP3 dt-bindings
From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date: 2021-09-07 00:11:27
Also in:
linux-devicetree, linux-media, linux-mediatek, lkml
Hi, Moudy: Moudy Ho [off-list ref] 於 2021年8月24日 週二 下午6:02寫道：
This patch adds DT binding document for Media Data Path 3 (MDP3) a unit in multimedia system used for scaling and color format convert. Signed-off-by: Moudy Ho <redacted> --- .../bindings/media/mediatek,mdp3-ccorr.yaml | 57 +++++ .../bindings/media/mediatek,mdp3-rdma.yaml | 207 ++++++++++++++++++ .../bindings/media/mediatek,mdp3-rsz.yaml | 65 ++++++ .../bindings/media/mediatek,mdp3-wdma.yaml | 71 ++++++ .../bindings/media/mediatek,mdp3-wrot.yaml | 71 ++++++ 5 files changed, 471 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-ccorr.yaml
I've compared ccorr driver in display [1] and ccorr in mdp [2], both are similar. So I would like both binding document are placed together. In display folder? In mdp folder? In SoC folder? I've no idea which one is better. At lease put together. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c?h=v5.14 [2] https://patchwork.kernel.org/project/linux-mediatek/patch/20210824100027.25989-6-moudy.ho@mediatek.com/ Regards, Chun-Kuang.
quoted hunk ↗ jump to hunk
create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-wdma.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yamldiff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-ccorr.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-ccorr.yaml new file mode 100644 index 000000000000..59fd68b46022 --- /dev/null +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-ccorr.yaml@@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/mediatek,mdp3-ccorr.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek Media Data Path 3 CCORR Device Tree Bindings + +maintainers: + - Daoyuan Huang <daoyuan.huang@mediatek.com> + - Moudy Ho <moudy.ho@mediatek.com> + +description: | + One of Media Data Path 3 (MDP3) components used to do color correction with 3X3 matrix. + +properties: + compatible: + items: + - enum: + - mediatek,mt8183-mdp3-ccorr + + mediatek,mdp3-id: + $ref: /schemas/types.yaml#/definitions/uint32 + maxItems: 1 + description: | + HW index to distinguish same functionality modules. + + reg: + description: | + Physical base address and length of the function block + register space, the number aligns with the component + and its own subcomponent. + + mediatek,gce-client-reg: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: | + sub-system id corresponding to the global command engine (GCE) + register address. + $ref: /schemas/mailbox/mtk-gce.txt + + clocks: + minItems: 1 + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/mt8183-clk.h> + #include <dt-bindings/gce/mt8183-gce.h> + + mdp3_ccorr: mdp3_ccorr@1401c000 { + compatible = "mediatek,mt8183-mdp3-ccorr"; + mediatek,mdp3-id = <0>; + reg = <0x1401c000 0x1000>; + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0xc000 0x1000>; + clocks = <&mmsys CLK_MM_MDP_CCORR>; + };
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel