[PATCH v3] clk: imx: use module_platform_driver

Subsystems: common clk framework, nxp i.mx clock drivers, the rest

STALE1762d LANDED

Landed in mainline as eee377b8f44e on 2021-12-03.

7 messages, 4 authors, 2021-12-13 · open the first message on its own page

[PATCH v3] clk: imx: use module_platform_driver

From: Miles Chen <hidden>
Date: 2021-09-04 23:54:29 

Replace builtin_platform_driver_probe with module_platform_driver_probe
because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).

Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Miles Chen <redacted>

---

Change since v2:
use correct Fixes tag

Change since v1:
Add Fixes tags

---
 drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +-
 drivers/clk/imx/clk-imx8qxp.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c
index d3e905cf867d..b23758083ce5 100644
--- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
+++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
@@ -370,7 +370,7 @@ static struct platform_driver imx8qxp_lpcg_clk_driver = {
 	.probe = imx8qxp_lpcg_clk_probe,
 };
 
-builtin_platform_driver(imx8qxp_lpcg_clk_driver);
+module_platform_driver(imx8qxp_lpcg_clk_driver);
 
 MODULE_AUTHOR("Aisheng Dong <aisheng.dong@nxp.com>");
 MODULE_DESCRIPTION("NXP i.MX8QXP LPCG clock driver");
diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c
index c53a688d8ccc..40a2efb1329b 100644
--- a/drivers/clk/imx/clk-imx8qxp.c
+++ b/drivers/clk/imx/clk-imx8qxp.c
@@ -308,7 +308,7 @@ static struct platform_driver imx8qxp_clk_driver = {
 	},
 	.probe = imx8qxp_clk_probe,
 };
-builtin_platform_driver(imx8qxp_clk_driver);
+module_platform_driver(imx8qxp_clk_driver);
 
 MODULE_AUTHOR("Aisheng Dong <aisheng.dong@nxp.com>");
 MODULE_DESCRIPTION("NXP i.MX8QXP clock driver");
-- 
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3] clk: imx: use module_platform_driver

From: Fabio Estevam <festevam@gmail.com>
Date: 2021-09-05 00:44:40 

Hi Miles,

On Sat, Sep 4, 2021 at 8:54 PM Miles Chen [off-list ref] wrote:
Replace builtin_platform_driver_probe with module_platform_driver_probe
because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).

Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Miles Chen <redacted>
Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3] clk: imx: use module_platform_driver

From: Stephen Boyd <sboyd@kernel.org>
Date: 2021-09-05 20:42:35 

Quoting Miles Chen (2021-09-04 16:54:18)
Replace builtin_platform_driver_probe with module_platform_driver_probe
because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).

Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Miles Chen <redacted>

---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3] clk: imx: use module_platform_driver

From: <hidden>
Date: 2021-11-05 05:59:53 

From: Miles Chen <redacted>

Hi Stephen,
quoted
Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Miles Chen <redacted>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Thanks for doing the review, I cannot find this patch in clk-imx tree,
Would you pick this patch, please?

Miles

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel





  

    
Re: [PATCH v3] clk: imx: use module_platform_driver

    

      From: Abel Vesa <hidden>

      Date: 2021-11-20 20:37:32 
    

  

  
On 21-11-05 13:59:32, miles.chen@mediatek.com wrote:
From: Miles Chen <redacted>

Hi Stephen,

quoted
quoted
Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Miles Chen <redacted>
quoted
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Thanks for doing the review, I cannot find this patch in clk-imx tree,
Would you pick this patch, please?
Sorry for the delay. 

Fixes are usually picked up directly by Stephen, 
therefore they're not going through clk-imx tree.

Stephen, can you pick this one up please?

Miles
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel





  

    
Re: [PATCH v3] clk: imx: use module_platform_driver

    

      From: Stephen Boyd <sboyd@kernel.org>

      Date: 2021-12-03 01:57:19 
    

  

  
Quoting Abel Vesa (2021-11-20 12:37:24)
On 21-11-05 13:59:32, miles.chen@mediatek.com wrote:
quoted
From: Miles Chen <redacted>

Hi Stephen,

quoted
quoted
Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Miles Chen <redacted>
quoted
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Thanks for doing the review, I cannot find this patch in clk-imx tree,
Would you pick this patch, please?
Sorry for the delay. 

Fixes are usually picked up directly by Stephen, 
therefore they're not going through clk-imx tree.

Stephen, can you pick this one up please?
It doesn't look like a very critical fix but ok. I suppose someone could
try to use =m for these files?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel





  

    
Re: [PATCH v3] clk: imx: use module_platform_driver

    

      From: Abel Vesa <hidden>

      Date: 2021-12-13 11:27:31 
    

  

  
On 21-12-02 17:57:13, Stephen Boyd wrote:
Quoting Abel Vesa (2021-11-20 12:37:24)
quoted
On 21-11-05 13:59:32, miles.chen@mediatek.com wrote:
quoted
From: Miles Chen <redacted>

Hi Stephen,

quoted
quoted
Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Miles Chen <redacted>
quoted
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Thanks for doing the review, I cannot find this patch in clk-imx tree,
Would you pick this patch, please?
Sorry for the delay. 

Fixes are usually picked up directly by Stephen, 
therefore they're not going through clk-imx tree.

Stephen, can you pick this one up please?
It doesn't look like a very critical fix but ok. I suppose someone could
try to use =m for these files?
Yes. I think this is for GKI.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help