[PATCH v3 02/10] iio: adc: at91-sama5d2_adc: initialize hardware after clock is started
flat view
STALE1854d
LANDED
From: Eugen Hristev <hidden>
Date: 2021-09-01 12:31:28
Also in:
linux-devicetree, linux-iio, lkml
Subsystem:
iio subsystem and drivers, microchip sama5d2-compatible adc driver, the rest · Maintainers:
Jonathan Cameron, Eugen Hristev, Linus Torvalds
Revision v3 of 2 in this series; landed in mainline as eaefa151f48a on 2021-09-14.
Revisions (2)
- v2 [diff vs current]
- v3 current
The hw_init hardware init call must happen after the clock is prepared and enabled. Otherwise, writing to the registers might lead to a block or external abort. Signed-off-by: Eugen Hristev <redacted> --- drivers/iio/adc/at91-sama5d2_adc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
index ea5ca163d879..1f4d461c2c18 100644
--- a/drivers/iio/adc/at91-sama5d2_adc.c
+++ b/drivers/iio/adc/at91-sama5d2_adc.c@@ -1833,12 +1833,12 @@ static int at91_adc_probe(struct platform_device *pdev) goto vref_disable; } - at91_adc_hw_init(indio_dev); - ret = clk_prepare_enable(st->per_clk); if (ret) goto vref_disable; + at91_adc_hw_init(indio_dev); + platform_set_drvdata(pdev, indio_dev); ret = at91_adc_buffer_and_trigger_init(&pdev->dev, indio_dev);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel