Thread (2 messages) flat view 2 messages, 2 authors, 2021-09-01

Re: [PATCH] media: s5p-jpeg: Make use of the helper function devm_platform_ioremap_resource()

From: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
Date: 2021-09-01 09:18:20
Also in: linux-media, lkml

Hi Cai Huoqing,

Thank you for the patch.

W dniu 01.09.2021 o 07:56, Cai Huoqing pisze:
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <redacted>
Acked-by: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
quoted hunk ↗ jump to hunk
---
  drivers/media/platform/s5p-jpeg/jpeg-core.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c
index d402e456f27d..1faff037cdf7 100644
--- a/drivers/media/platform/s5p-jpeg/jpeg-core.c
+++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c
@@ -2850,7 +2850,6 @@ static void *jpeg_get_drv_data(struct device *dev);
  static int s5p_jpeg_probe(struct platform_device *pdev)
  {
  	struct s5p_jpeg *jpeg;
-	struct resource *res;
  	int i, ret;
  
  	/* JPEG IP abstraction struct */
@@ -2867,9 +2866,7 @@ static int s5p_jpeg_probe(struct platform_device *pdev)
  	jpeg->dev = &pdev->dev;
  
  	/* memory-mapped registers */
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-
-	jpeg->regs = devm_ioremap_resource(&pdev->dev, res);
+	jpeg->regs = devm_platform_ioremap_resource(pdev, 0);
  	if (IS_ERR(jpeg->regs))
  		return PTR_ERR(jpeg->regs);
  
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help