Re: [PATCH] media: sti/c8sectpfe: Make use of the helper function devm_platform_ioremap_resource_byname()
flat view
From: Hans Verkuil <hidden>
Date: 2021-09-01 08:20:38
Also in:
linux-media, lkml
On 01/09/2021 07:56, Cai Huoqing wrote:
quoted hunk ↗ jump to hunk
Use the devm_platform_ioremap_resource_byname() helper instead of calling platform_get_resource_byname() and devm_ioremap_resource() separately Signed-off-by: Cai Huoqing <redacted> --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c index 02dc78bd7fab..9f05984f711a 100644 --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c@@ -665,7 +665,6 @@ static int c8sectpfe_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct device_node *child, *np = dev->of_node; struct c8sectpfei *fei; - struct resource *res; int ret, index = 0; struct channel_info *tsin;@@ -676,14 +675,11 @@ static int c8sectpfe_probe(struct platform_device *pdev) fei->dev = dev; - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "c8sectpfe"); - fei->io = devm_ioremap_resource(dev, res); + fei->io = devm_platform_ioremap_resource_byname(pdev, "c8sectpfe"); if (IS_ERR(fei->io)) return PTR_ERR(fei->io); - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, - "c8sectpfe-ram"); - fei->sram = devm_ioremap_resource(dev, res); + fei->sram = devm_platform_ioremap_resource_byname(pdev, "c8sectpfe-ram"); if (IS_ERR(fei->sram)) return PTR_ERR(fei->sram);
Compile error:
drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c: In function ‘c8sectpfe_probe’:
drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c:686:33: error: ‘res’ undeclared (first use in this function); did you mean ‘ret’?
686 | fei->sram_size = resource_size(res);
| ^~~
| ret
drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c:686:33: note: each undeclared identifier is reported only once for each function it appears in
Regards,
Hans
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel