Re: [PATCH v10 1/2] dt-bindings: pinctrl: mt8195: add rsel define

On Tue, 2021-08-17 at 01:00 +0200, Linus Walleij wrote:

On Mon, Aug 16, 2021 at 5:38 PM Chen-Yu Tsai [off-list ref]
wrote:

quoted

On Mon, Aug 16, 2021 at 6:48 PM zhiyong.tao <
zhiyong.tao@mediatek.com> wrote:

quoted

quoted

I'll take that as "use SI units whenever possible and
reasonable".

==> so It doesn't need to change the define, is it right?
we will keep the common define.

Actually I think it would be possible and reasonable to use SI
units
in this case, since you are the vendor and have the resistor values
to implement the support. Having different sets of values for
different
chips is nothing out of the ordinary. We already have to account
for
different number of pins and different pin functions. That is what
compatible strings are for.

I fully agree with Chen-Yu's analysis here.

Zhiyong can you make an attempt to use SI units (Ohms) and see
what it will look like? I think it will look better for users and it
will
be less risk to make mistakes.

Yours,
Linus Walleij

Hi Linus & chen-yu,

The rsel actual bias resistance of each setting is different in
different IC. For example, in mt8195, the rsel actual bias resistance
setting like as:
MTK_PULL_SET_RSEL_000:75K in PU, 75k in PD;
MTK_PULL_SET
_RSEL_001:10k in PU, 5k in PD;
MTK_PULL_SET_RSEL_010:5k in PU, 75k in
PD;
MTK_PULL_SET_RSEL_011:4k in PU, 5K in PD;
MTK_PULL_SET_RSEL_100:3k in
PU, 75k in PD;
MTK_PULL_SET_RSEL_101:2k in PU, 5K in PD;
MTK_PULL_SET_RSE
L_110:1.5k in PU, 75k in PD;
MTK_PULL_SET_RSEL_111:1k in PU, 5k in PD.

but in mt8192, the rsel actual bias resistance setting like as:
MTK_PULL_SET_RSEL_000:75K in PU, 75k in PD;
MTK_PULL_SET_RSEL_001:3k in PU, 5k in PD;
MTK_PULL_SET_RSEL_010:10k in PU, 75k in PD;
MTK_PULL_SET_RSEL_011:1k in PU, 5K in PD;

Can you help me to provide a suggestion common define for the all
different IC?
It seems that we should add a new define, if we upstream a new IC
pinctrl driver in the future.

Thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel