-----Original Message-----
From: Ulf Hansson [mailto:ulf.hansson@linaro.org]
Sent: 2021年8月24日 21:53
To: Bough Chen <haibo.chen@nxp.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>; Shawn Guo
[off-list ref]; Rob Herring [off-list ref]; Sascha Hauer
[off-list ref]; Sascha Hauer [off-list ref]; Fabio
Estevam [off-list ref]; linux-mmc [off-list ref];
dl-linux-imx [off-list ref]; DTML [off-list ref]; Linux
ARM [off-list ref]
Subject: Re: [PATCH 1/6] mmc: sdhci-esdhc-imx: remove redundant code for
manual tuning

On Mon, 16 Aug 2021 at 15:00, [off-list ref] wrote:

quoted

From: Haibo Chen <haibo.chen@nxp.com>

For manual tuning method, already call esdhc_prepare_tuning() config
the necessary registers, so remove the redundant code in
esdhc_writew_le() for SDHCI_HOST_CONTROL2.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>

While discussions on the DT binding, etc, continue with Lucas and Rob on patch
3 - do you want me to apply patch1 and patch2?

Yes, thanks!
Let's wait comments for patch 3.

Best Regards
Haibo Chen

Kind regards
Uffe

quoted

---
 drivers/mmc/host/sdhci-esdhc-imx.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c

b/drivers/mmc/host/sdhci-esdhc-imx.c
index 57b19ca1ad6d..a49fac719fca 100644

--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c

@@ -628,17 +628,7 @@ static void esdhc_writew_le(struct sdhci_host

*host, u16 val, int reg)

quoted

                else
                        new_val &=

~ESDHC_VENDOR_SPEC_VSELECT;

quoted

                writel(new_val, host->ioaddr + ESDHC_VENDOR_SPEC);
-               if (imx_data->socdata->flags &

ESDHC_FLAG_MAN_TUNING) {

quoted

-                       new_val = readl(host->ioaddr +

ESDHC_MIX_CTRL);

quoted

-                       if (val & SDHCI_CTRL_TUNED_CLK) {
-                               new_val |=

ESDHC_MIX_CTRL_SMPCLK_SEL;

quoted

-                               new_val |=

ESDHC_MIX_CTRL_AUTO_TUNE_EN;

quoted

-                       } else {
-                               new_val &=

~ESDHC_MIX_CTRL_SMPCLK_SEL;

quoted

-                               new_val &=

~ESDHC_MIX_CTRL_AUTO_TUNE_EN;

quoted

-                       }
-                       writel(new_val , host->ioaddr +

ESDHC_MIX_CTRL);

quoted

-               } else if (imx_data->socdata->flags &

ESDHC_FLAG_STD_TUNING) {

quoted

+               if (imx_data->socdata->flags &

ESDHC_FLAG_STD_TUNING)

quoted

+ {
                        u32 v = readl(host->ioaddr +

SDHCI_AUTO_CMD_STATUS);

quoted

                        u32 m = readl(host->ioaddr +

ESDHC_MIX_CTRL);

quoted

                        if (val & SDHCI_CTRL_TUNED_CLK) {
--
2.17.1