Re: [RESEND PATCH 3/4] clk: mediatek: support COMMON_CLK_MT6779 module build
From: Stephen Boyd <sboyd@kernel.org>
Date: 2021-08-29 04:15:01
Also in:
linux-clk, linux-mediatek, lkml
Quoting Miles Chen (2021-08-12 20:24:28)
quoted hunk ↗ jump to hunk
diff --git a/drivers/clk/mediatek/clk-mt6779-aud.c b/drivers/clk/mediatek/clk-mt6779-aud.c index 11b209f95e25..439c0bc94b73 100644 --- a/drivers/clk/mediatek/clk-mt6779-aud.c +++ b/drivers/clk/mediatek/clk-mt6779-aud.c@@ -4,6 +4,7 @@ * Author: Wendell Lin <wendell.lin@mediatek.com> */ +#include <linux/module.h> #include <linux/clk-provider.h> #include <linux/of.h> #include <linux/of_address.h>@@ -115,3 +116,4 @@ static struct platform_driver clk_mt6779_aud_drv = { }; builtin_platform_driver(clk_mt6779_aud_drv); +MODULE_LICENSE("GPL");
How does this work? builtin_platform_driver() means that it's not modular code. Shouldn't that be module_platform_driver()? Have you tried loading and unloading the module? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel