Re: [PATCH 4/4] mm: kfence: Only load kfence_test when kfence is enabled

On 2021/8/25 17:31, Alexander Potapenko wrote:

On Wed, Aug 25, 2021 at 11:17 AM Kefeng Wang [off-list ref] wrote:

quoted

Provide kfence_is_enabled() helper, only load kfence_test module
when kfence is enabled.

What's wrong with the current behavior?
I think we need at least some way to tell the developer that KFENCE
does not work, and a failing test seems to be the perfect one.

If the kfence is not enabled, eg kfence.sample_interval=0, kfence_test 
spend too much time,

and all tests will fails. It is meaningless. so better to just skip it ;)

quoted

diff --git a/mm/kfence/kfence_test.c b/mm/kfence/kfence_test.c
index eb6307c199ea..4087f9f1497e 100644
--- a/mm/kfence/kfence_test.c
+++ b/mm/kfence/kfence_test.c

@@ -847,6 +847,8 @@ static void unregister_tracepoints(struct tracepoint *tp, void *ignore)
   */
  static int __init kfence_test_init(void)
  {
+       if (!kfence_is_enabled())

Add a print info here?

quoted

+               return 0;
         /*
          * Because we want to be able to build the test as a module, we need to
          * iterate through all known tracepoints, since the static registration
--
2.26.2

--
You received this message because you are subscribed to the Google Groups "kasan-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20210825092116.149975-5-wangkefeng.wang%40huawei.com.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel