Re: [PATCH v2 1/4] ASoC: rockchip: add support for i2s-tdm controller
From: Mark Brown <broonie@kernel.org>
Date: 2021-08-23 11:20:08
Also in:
alsa-devel, linux-rockchip, lkml
On Sat, Aug 21, 2021 at 10:45:52PM +0200, Nicolas Frattaroli wrote:
On Freitag, 20. August 2021 21:02:16 CEST Pierre-Louis Bossart wrote:quoted
quoted
+ regmap_read(i2s_tdm->regmap, I2S_CLR, &val); + /* Wait on the clear operation to finish */ + while (val) {
quoted
delay needed here?
The rockchip_i2s.c code doesn't have a delay here either, but I can add one of 1 usec for good measure, it seems weird to retry the read as fast as it can.
You should probably have a cpu_relax() in there at least.