Re: [PATCH] watchdog: stm32_iwdg: drop superfluous error message
From: Guenter Roeck <linux@roeck-us.net>
Date: 2021-08-14 15:02:33
Also in:
linux-watchdog, lkml
On 8/14/21 7:27 AM, Tang Bin wrote:
In the function stm32_iwdg_probe(), devm_platform_ioremap_resource has already contained error message, so drop the redundant one. Co-developed-by: Zhang Shengju <redacted> Signed-off-by: Zhang Shengju <redacted> Signed-off-by: Tang Bin <redacted>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
quoted hunk ↗ jump to hunk
--- drivers/watchdog/stm32_iwdg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c index a3436c296..570a71509 100644 --- a/drivers/watchdog/stm32_iwdg.c +++ b/drivers/watchdog/stm32_iwdg.c@@ -237,10 +237,8 @@ static int stm32_iwdg_probe(struct platform_device *pdev) /* This is the timer base. */ wdt->regs = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(wdt->regs)) { - dev_err(dev, "Could not get resource\n"); + if (IS_ERR(wdt->regs)) return PTR_ERR(wdt->regs); - } ret = stm32_iwdg_clk_init(pdev, wdt); if (ret)
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel