RE: [EXT] Re: [PATCH v1] arm64: dts: fsl: ls1028a-rdb: Add dts file to choose swp5 as dsa master
From: Hongbo Wang <hidden>
Date: 2021-08-13 13:57:00
Also in:
linux-devicetree, lkml, netdev
On Fri, Aug 13, 2021 at 11:01:55AM +0800, hongbo.wang@nxp.com wrote:quoted
From: hongbo wang <redacted> some use cases want to use swp4-eno2 link as ordinary data path, so we can enable swp5 as dsa master, the data from kernel can be transmitted to eno3, then send to swp5 via internal link, switch will forward it to swp0-3. the data to kernel will come from swp0-3, and received by kernel via swp5-eno3 link.quoted
new file mode 100644 index 000000000000..a88396c137a1--- /dev/null +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb-dsa-swp5-eno3.dts@@ -0,0 +1,27 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Device Tree file for NXP LS1028A RDB with dsa master swp5-eno3. + * + * Copyright 2018-2021 NXP + * + * Hongbo Wang <hongbo.wang@nxp.com> + * + */ + +/dts-v1/; +#include "fsl-ls1028a-rdb.dts"You will end up with two DT blobs with the same top level compatible. This is going to cause confusion. I suggest you add an additional top level compatible to make it clear this differs from the compatible = "fsl,ls1028a-rdb", "fsl,ls1028a" blob. Andrew
hi Andrew, thanks for comments. this "fsl-ls1028a-rdb-dsa-swp5-eno3.dts" is also for fsl-ls1028a-rdb platform, the only difference with "fsl-ls1028a-rdb.dts" is that it use swp5 as dsa master, not swp4, and it's based on "fsl-ls1028a-rdb.dts", so I choose this manner, if "fsl-ls1028a-rdb.dts" has some modification for new version, this file don't need be changed. thanks, hongbo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel