Re: [PATCH v3 05/13] genirq: Let purely flow-masked ONESHOT irqs through unmask_threaded_irq()
From: Marc Zyngier <maz@kernel.org>
Date: 2021-08-12 07:26:54
Also in:
lkml
On Tue, 29 Jun 2021 13:50:02 +0100, Valentin Schneider [off-list ref] wrote:
quoted hunk ↗ jump to hunk
A subsequent patch will let IRQs end up in irq_finalize_oneshot() without IRQD_IRQ_MASKED, but with IRQD_IRQ_FLOW_MASKED set instead. Let such IRQs receive their final ->irq_eoi(). Signed-off-by: Valentin Schneider <redacted> --- kernel/irq/manage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index ef30b4762947..e6d6d32ddcbc 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c@@ -1107,7 +1107,7 @@ static void irq_finalize_oneshot(struct irq_desc *desc, desc->threads_oneshot &= ~action->thread_mask; if (!desc->threads_oneshot && !irqd_irq_disabled(&desc->irq_data) && - irqd_irq_masked(&desc->irq_data)) + (irqd_irq_masked(&desc->irq_data) | irqd_irq_flow_masked(&desc->irq_data))) unmask_threaded_irq(desc);
The bitwise OR looks pretty odd. It is probably fine given that both side of the expression are bool, but still. I can fix this locally. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel