Re: [PATCH] ARM/smp_twd: Cleanup the unnecessary cast
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2021-08-11 13:31:34
Also in:
lkml
On Wed, Aug 11, 2021 at 09:15:12PM +0800, Tang Bin wrote:
quoted hunk ↗ jump to hunk
It's not necessary to specify 'int' castingfor 'PTR_ERR(twd_clk)'. Signed-off-by: Tang Bin <redacted> --- arch/arm/kernel/smp_twd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c index 9a14f721a..423e9079d 100644 --- a/arch/arm/kernel/smp_twd.c +++ b/arch/arm/kernel/smp_twd.c@@ -199,7 +199,7 @@ static void twd_get_clock(struct device_node *np) twd_clk = clk_get_sys("smp_twd", NULL); if (IS_ERR(twd_clk)) { - pr_err("smp_twd: clock not found %d\n", (int) PTR_ERR(twd_clk)); + pr_err("smp_twd: clock not found %d\n", PTR_ERR(twd_clk));
Sorry, NAK. This change _will_ produce a compiler warning. "%d" expects an argument of type "int", but PTR_ERR() returns a type of "long". Sorry, but the cast is entirely necessary. A better solution today would be to get rid of the PTR_ERR() entirely and use %pe, which will get us a textual description of the error when the appropriate kernel configuration option is enabled. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel