Re: [PATCH] reset: reset-zynqmp: Fixed the argument data type
From: Michael Tretter <m.tretter@pengutronix.de>
Date: 2021-08-11 10:36:26
Also in:
lkml
On Wed, 23 Jun 2021 13:46:20 +0200, Michal Simek wrote:
quoted hunk ↗ jump to hunk
From: Sai Krishna Potthuri <redacted> This patch changes the data type of the variable 'val' from int to u32. Signed-off-by: Sai Krishna Potthuri <redacted> Signed-off-by: Michal Simek <redacted> Addresses-Coverity: argument of type "int *" is incompatible with parameter of type "u32 *" --- drivers/reset/reset-zynqmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c index daa425e74c96..59dc0ff9af9e 100644 --- a/drivers/reset/reset-zynqmp.c +++ b/drivers/reset/reset-zynqmp.c@@ -53,7 +53,8 @@ static int zynqmp_reset_status(struct reset_controller_dev *rcdev, unsigned long id) { struct zynqmp_reset_data *priv = to_zynqmp_reset_data(rcdev); - int val, err; + int err; + u32 val;
The function returns val as int instead of u32. While this shouldn't be a problem in this case, maybe there should be an additional check just to be sure? Michael
err = zynqmp_pm_reset_get_status(priv->data->reset_id + id, &val); if (err) -- 2.32.0
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel