Thread (31 messages) 31 messages, 4 authors, 2021-08-11

Re: [PATCH 8/8] cpufreq: vexpress: Use auto-registration for energy model

From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2021-08-10 10:06:58
Also in: linux-pm, lkml

On 10-08-21, 11:05, Lukasz Luba wrote:
I can see that this driver calls explicitly the
of_cpufreq_cooling_register()
It does this in the cpufreq_driver->ready() callback
implementation: ve_spc_cpufreq_ready()

With that in mind, the new code in the patch 1/8, which
registers the EM, should be called even earlier, above:
---------------------8<---------------------------------
/* Callback for handling stuff after policy is ready */
	if (cpufreq_driver->ready)
		cpufreq_driver->ready(policy);
------------------->8----------------------------------
Thanks. I will look at this sequencing issue again.
This also triggered a question:
If this new flag can be set in the cpufreq driver which hasn't set
CPUFREQ_IS_COOLING_DEV
?
Why not ?
I can only see one driver (this one in the patch) which has such
configuration.
-- 
viresh

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help