Re: [PATCH 3/5] ARM: dts: Add basic support for EcoNet EN7523
From: Bert Vermeulen <hidden>
Date: 2021-08-04 16:42:19
Also in:
linux-devicetree, lkml
On 7/30/21 4:46 PM, Mark Rutland wrote:
On Fri, Jul 30, 2021 at 03:45:50PM +0200, Bert Vermeulen wrote:quoted
+ timer { + compatible = "arm,armv8-timer";This should be "arm,armv7-timer".quoted
+ interrupt-parent = <&gic>; + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;GICv3 doesn't have a cpumask in its PPI description, so the GIC_CPU_MASK_SIMPLE() bits should be removed.
Ok, will fix.
quoted
+ clock-frequency = <25000000>;Please have your FW configure CNTFRQ on each CPU; the clock-frequency property in the DT is a workaround for broken FW, and it's *vastly* preferable for FW to configure this correctly (e.g. as it means VMs should "just work").
I've since got hold of the modified U-Boot that runs on my eval board, and indeed it doesn't set CNTFRQ. So the kernel does need this, for the moment. I may get a chance to upstream support for this SoC in U-Boot, but I can't control what people are going to ship with their board. Is it ok to leave this in? -- Bert Vermeulen bert@biot.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel