Re: [PATCH linux-next] 'linux/tty.h' included in 'hackkit.c' is duplicated. It is also included in the 21th line.
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2021-08-04 10:14:17
Also in:
lkml
On Wed, Aug 04, 2021 at 02:39:07AM -0700, cgel.zte@gmail.com wrote:
From: yong yiran <redacted> Reported-by: Zeal Robot <redacted> Signed-off-by: yong yiran <redacted>
Hi, The commit message and summary(subject) could do with some improvement: 1) I don't think having "It is also included in the 21th line." in the summary adds value. 2) Maybe the summary should be "Remove duplicated 'linux/tty.h' include in 'hackkit.c'" 3) the commit message should say something, maybe along the lines of: "Remove all but the first include of linux/tty.h from hackkit.c." Thanks.
quoted hunk ↗ jump to hunk
--- arch/arm/mach-sa1100/hackkit.c | 1 - 1 file changed, 1 deletion(-)diff --git a/arch/arm/mach-sa1100/hackkit.c b/arch/arm/mach-sa1100/hackkit.c index 3085f1c2e586..3fe34ee7c0ab 100644 --- a/arch/arm/mach-sa1100/hackkit.c +++ b/arch/arm/mach-sa1100/hackkit.c@@ -18,7 +18,6 @@ #include <linux/serial_core.h> #include <linux/mtd/mtd.h> #include <linux/mtd/partitions.h> -#include <linux/tty.h> #include <linux/gpio.h> #include <linux/leds.h> #include <linux/platform_device.h>-- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel