Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module
From: Saravana Kannan <hidden>
Date: 2021-08-04 02:12:39
Also in:
linux-amlogic, lkml
On Tue, Aug 3, 2021 at 2:51 AM Marc Zyngier [off-list ref] wrote:
On Tue, 03 Aug 2021 10:44:34 +0100, Marc Zyngier [off-list ref] wrote: [...]quoted
This thing keeps failing on my end. It only works if I force the irqchip module to be present before the MDIO module is loaded. Here's an example: root@tiger-roach:~# modprobe mdio_mux_meson_g12a [ 125.871544] libphy: mdio_mux: probed [ 125.882575] g12a-mdio_mux ff64c000.mdio-multiplexer: Error: Failed to register MDIO bus for child /soc/bus@ff600000/mdio-multiplexer@4c000/mdio@0 [ 125.892630] libphy: mdio_mux: probed Trying to bring up the Ethernet interface will fail. Note that there was no attempt to load the irqchip driver. root@tiger-roach:~# modprobe -r mdio_mux_meson_g12a root@tiger-roach:~# modprobe irq-meson-gpio [ 144.983344] meson-gpio-intc ffd0f080.interrupt-controller: 100 to 8 gpio interrupt mux initialized root@tiger-roach:~# modprobe mdio_mux_meson_g12a [ 150.376464] libphy: mdio_mux: probed [ 150.391039] libphy: mdio_mux: probed And it now works.An additional source of amusement is that this patch allows the irqchip to be removed from the kernel. It becomes really fun when you have live interrupts...
Which is why I wrote IRQCHIP_PLATFORM_DRIVER_BEGIN/END macros. Maybe those should be used instead? -Saravana [1] - https://lore.kernel.org/lkml/20200718000637.3632841-2-saravanak@google.com/ (local) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel