Re: [PATCH net-next v2 2/4] net: dsa: mt7530: use independent VLAN learning on VLAN-unaware bridges
From: DENG Qingfang <dqfext@gmail.com>
Date: 2021-08-03 17:14:01
Also in:
linux-mediatek, lkml, netdev
On Tue, Aug 03, 2021 at 07:48:53PM +0300, Vladimir Oltean wrote:
After this patch set gets merged, can you also please take a look at the following: Documentation/networking/switchdev.rst says: When the bridge has VLAN filtering enabled and a PVID is not configured on the ingress port, untagged and 802.1p tagged packets must be dropped. When the bridge has VLAN filtering enabled and a PVID exists on the ingress port, untagged and priority-tagged packets must be accepted and forwarded according to the bridge's port membership of the PVID VLAN. When the bridge has VLAN filtering disabled, the presence/lack of a PVID should not influence the packet forwarding decision. I'm not sure if this happens or not with mt7530, since the driver attempts to change the pvid back to 0. You are not changing this behavior in this series, so no reason to deal with it as part of it.
There is PVC.ACC_FRM which controls the acceptable frame type. Currently the driver does not use it, so untagged and priority-tagged frames can get into a VLAN-aware port without a PVID. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel