Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y)
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2021-08-02 02:36:29
Also in:
linux-mips, linux-riscv, linuxppc-dev, lkml
Masahiro Yamada [off-list ref] writes:
arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY, hence $(gettimeofday-y) never becomes empty. riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y, but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that condition. So, you can always define CFLAGS_vgettimeofday.o Remove all the meaningless conditionals. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- Changes in v2: - Fix csky as well arch/arm/vdso/Makefile | 4 ---- arch/arm64/kernel/vdso/Makefile | 5 +---- arch/arm64/kernel/vdso32/Makefile | 3 --- arch/csky/kernel/vdso/Makefile | 4 +--- arch/mips/vdso/Makefile | 2 -- arch/powerpc/kernel/vdso32/Makefile | 14 ++++++-------- arch/powerpc/kernel/vdso64/Makefile | 14 ++++++--------
I noticed this the other day and was puzzled why we still needed the conditional, thanks for cleaning it up. Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) cheers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel