Re: [PATCH v2] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features
From: Sam Ravnborg <hidden>
Date: 2021-07-26 13:43:49
Also in:
dri-devel, linux-mediatek
Hi Nicolas, On Mon, Jul 26, 2021 at 08:38:18AM +0800, Nicolas Boichat wrote:
On Sun, Jul 25, 2021 at 9:31 PM Sam Ravnborg [off-list ref] wrote:quoted
On Tue, Jun 29, 2021 at 07:47:21AM +0800, Nicolas Boichat wrote:quoted
Many of the DSI flags have names opposite to their actual effects, e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually be disabled. Fix this by including _NO_ in the flag names, e.g. MIPI_DSI_MODE_NO_EOT_PACKET. Signed-off-by: Nicolas Boichat <redacted>Hi Nicolas, in this thread: https://lore.kernel.org/dri-devel/20210211113309.1.I629b2366a6591410359c7fcf6d385b474b705ca2@changeid/ (local) I see that several people added their Reviewed-by. Please either add the tgas if missing, or elaborate why you left them out.Oh simple, I just forgot.
Yeah, know that feeling.
I regenerated the patch so it's a bit different from v1... Not 100% sure if I can add those, since those were for the overall patch: Reviewed-by: Robert Foss <redacted> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Andrzej Hajda <redacted>. Those 2 shouldn't be a problem: Reviewed-by: Xin Ji <redacted> # anx7625.c Reviewed-by: Abhinav Kumar <redacted> # msm/dsiquoted
I was suprised this had not landed yet.Yep. Let me know if you want me to send a v3 with those tags.
Please resend a v3 with the tags. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel