Re: [PATCH v1 5/7] drm/mediatek: Drop chain_mode_fixup call in mode_valid()
From: Maxime Ripard <hidden>
Date: 2021-07-22 07:33:47
Also in:
dri-devel, linux-mediatek
From: Maxime Ripard <hidden>
Date: 2021-07-22 07:33:47
Also in:
dri-devel, linux-mediatek
On Thu, Jul 22, 2021 at 08:22:44AM +0200, Sam Ravnborg wrote:
The mode_valid implementation had a call to drm_bridge_chain_mode_fixup() which would be wrong as the mode_valid is not allowed to change anything - only to validate the mode. As the next bridge is often/always a connector the call had no effect anyway. So drop it. From the git history I could see this call was included in the original version of the driver so there was no help there to find out why it was added in the first place. But a lot has changed since the initial driver were added and is seems safe to remove the call now. Signed-off-by: Sam Ravnborg <redacted> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: Matthias Brugger <matthias.bgg@gmail.com> Cc: Dafna Hirschfeld <redacted> Cc: linux-mediatek@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org
Reviewed-by: Maxime Ripard <redacted> Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel