RE: [PATCH 1/4] remoteproc: fix the wrong default value of is_iomem
From: Peng Fan <peng.fan@nxp.com>
Date: 2021-07-07 02:16:34
Also in:
linux-remoteproc
Subject: [PATCH 1/4] remoteproc: fix the wrong default value of is_iomem
Currently the is_iomem is a random value in the stack which may be default
to true even on those platforms that not use iomem to store firmware.
Cc: Bjorn Andersson <redacted>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Peng Fan <peng.fan@nxp.com>
Fixes: 40df0a91b2a5 ("remoteproc: add is_iomem to da_to_va")
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---Please also include rproc_copy_segment. Thanks, Peng.
quoted hunk ↗ jump to hunk
drivers/remoteproc/remoteproc_elf_loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/remoteproc/remoteproc_elf_loader.cb/drivers/remoteproc/remoteproc_elf_loader.c index 469c52e62faf..2bee4d5a0995 100644--- a/drivers/remoteproc/remoteproc_elf_loader.c +++ b/drivers/remoteproc/remoteproc_elf_loader.c@@ -178,8 +178,8 @@ int rproc_elf_load_segments(struct rproc *rproc,const struct firmware *fw) u64 filesz = elf_phdr_get_p_filesz(class, phdr); u64 offset = elf_phdr_get_p_offset(class, phdr); u32 type = elf_phdr_get_p_type(class, phdr); + bool is_iomem = false; void *ptr; - bool is_iomem; if (type != PT_LOAD) continue; -- 2.25.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel