Re: [PATCH 0/7] Add STM32MP13 SoCs and discovery board support
From: Arnd Bergmann <arnd@arndb.de>
Date: 2021-07-23 13:46:34
Also in:
linux-devicetree, linux-doc, linux-gpio
From: Arnd Bergmann <arnd@arndb.de>
Date: 2021-07-23 13:46:34
Also in:
linux-devicetree, linux-doc, linux-gpio
On Fri, Jul 23, 2021 at 3:28 PM Alexandre Torgue [off-list ref] wrote:
This series enhance the STM32 MPU family by adding STM32MP13 SoCs support. It adds machine support and device tree diversity to support the whole stm32mp13 family (STM32MP131/STM32MP133/STM32MP135, plus security feature diversity). Basically STM32MP13 SoCs embeds one Cortex A7, storage (SD/MMC/SDIO, QSPI FMC), network (ETH, CAN), display (DCMIPP, LTDC, ...), audio(SAI, DFSDM, SPDIFRX), com (USB EHCI/OHCI, USB OTG, I2C, SPI/I2S, U(S)ART). This series also adds STM32MP135F Discovery board support (stm32mp135f-dk). It embeds a STM32MP135f SOC with 512 MB of DDR3. Several connections are available on this board: - 4*USB2.0, 1*USB2.0 typeC DRD, SDcard, 2*RJ45, HDMI, Combo Wifi/BT, ... Only SD card, uart4 (console) and watchdog IPs are enabled in this commit. Note that file stm32mp135.dtsi doesn't define nodes but I add it now to ease adding of new nodes in a (close) future.
I had a brief look and it seems all fine to me, nice work! The only (very minor) thing I noticed is that the crypto engine device node has an unusual name 'cryp@' instead of the usual 'crypto@', but this is already the case on stm32mp157. With this changed, Acked-by: Arnd Bergmann <arnd@arndb.de _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel