Re: [PATCH 0/5] DT schema changes for HiKey970 PCIe hardware to work
From: Rob Herring <robh@kernel.org>
Date: 2021-07-29 17:20:55
Also in:
linux-devicetree, linux-pci, linux-phy, lkml
On Thu, Jul 29, 2021 at 5:56 AM Mauro Carvalho Chehab [off-list ref] wrote:
Hi Rob,
After our discussions, I'm opting to submit first the DT bindings for the
Kirin 970 PCIe support.
Patch 1 is there just because patch 2 needs. You already acked on it.
Patch 5 is also there just as an example of the entire stuff added to
the DTS file.
The core of this series are patches 2 to 4. They contain the conversion
of the kirin-pcie.txt file to the DT schema, and adds the needed
bindings.
Currently, it generates some warnings:
Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@f5000000: pcie@4,0:compatible: None of ['pciclass,0604'] are valid under the given schema
From schema: Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.yamlThis should be fixed now in dtschema master.
Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@4,0: reset-gpios: [[4294967295, 1, 0]] is too short
Your proposed change to pci-bus.yaml is wrong. It's requiring 4 entries. You need 'minItems: 1'. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel