Re: [PATCH 2/2] arm64: dts: rockchip: rk3568-evb1-v10: add ethernet support
From: Michael Riesch <hidden>
Date: 2021-07-29 09:07:57
Also in:
linux-devicetree, linux-rockchip, lkml
Hello Andrew, Peter, On 7/28/21 10:37 PM, Andrew Lunn wrote:
quoted
Generally all rockchip boards use this value instead of the rgmii_id, I imagine because it's more consistent to tune here than the hit or miss support of the phy drivers.Most PHY drivers actually implement it correctly, since by default, most systems get the PHY to do the delays. But if most Rockchip boards do it this way, there is a lot to be said for consistence, so this is fine by me.
I have tested a dts without the delays and with phy-mode = "rgmii-id" and it seems to work just fine. Although consistency with other Rockchip boards is something one should consider, I think I'll go along the "rgmii-id" path since this seems to be a more general convention. Thanks for your comments, I'll submit a v2. Regards, Michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel