Thread (28 messages) 28 messages, 3 authors, 2021-08-03

Re: [PATCH v2 08/11] memory: mtk-smi: Use devm_platform_ioremap_resource

From: Ikjoon Jang <hidden>
Date: 2021-07-21 11:56:54
Also in: linux-devicetree, linux-iommu, linux-mediatek, lkml

On Thu, Jul 15, 2021 at 8:24 PM Yong Wu [off-list ref] wrote:
No functional change. Simplify probing code.

Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Reviewed-by: Ikjoon Jang <redacted>
quoted hunk ↗ jump to hunk
---
 drivers/memory/mtk-smi.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index ee49bb50f5f5..e5a34b3952a0 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -317,7 +317,6 @@ static int mtk_smi_dts_clk_init(struct device *dev, struct mtk_smi *smi,
 static int mtk_smi_larb_probe(struct platform_device *pdev)
 {
        struct mtk_smi_larb *larb;
-       struct resource *res;
        struct device *dev = &pdev->dev;
        int ret;
@@ -326,8 +325,7 @@ static int mtk_smi_larb_probe(struct platform_device *pdev)
                return -ENOMEM;

        larb->larb_gen = of_device_get_match_data(dev);
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       larb->base = devm_ioremap_resource(dev, res);
+       larb->base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(larb->base))
                return PTR_ERR(larb->base);
@@ -447,7 +445,6 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        struct mtk_smi *common;
-       struct resource *res;
        int ret;

        common = devm_kzalloc(dev, sizeof(*common), GFP_KERNEL);
@@ -468,8 +465,7 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
         * base.
         */
        if (common->plat->type == MTK_SMI_GEN1) {
-               res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-               common->smi_ao_base = devm_ioremap_resource(dev, res);
+               common->smi_ao_base = devm_platform_ioremap_resource(pdev, 0);
                if (IS_ERR(common->smi_ao_base))
                        return PTR_ERR(common->smi_ao_base);
@@ -481,8 +477,7 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
                if (ret)
                        return ret;
        } else {
-               res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-               common->base = devm_ioremap_resource(dev, res);
+               common->base = devm_platform_ioremap_resource(pdev, 0);
                if (IS_ERR(common->base))
                        return PTR_ERR(common->base);
        }
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help