RE: [PATCH v2 00/10] i2c: xiic: Add features, bug fixes.

-----Original Message-----
From: Marek Vasut <marex@denx.de>
Sent: Friday, July 16, 2021 9:31 PM
To: Michal Simek <redacted>; Raviteja Narayanam
[off-list ref]; linux-i2c@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; git
[off-list ref]; joe@perches.com
Subject: Re: [PATCH v2 00/10] i2c: xiic: Add features, bug fixes.

On 6/28/21 9:23 AM, Michal Simek wrote:

quoted

On 6/26/21 12:27 PM, Raviteja Narayanam wrote:

quoted

-Add 'standard mode' feature for reads > 255 bytes.
-Add 'smbus block read' functionality.
-Add 'xlnx,axi-iic-2.1' new IP version support.
-Switch to 'AXI I2C standard mode' for i2c reads in affected IP versions.
-Remove 'local_irq_save/restore' calls as discussed here:

https://www.spinics.net/lists/linux-i2c/msg46483.html.

quoted

quoted

-Some trivial fixes.

Changes in v2:
-Grouped the commits as fixes first and then features.
-The first 4 commits fix the dynamic mode broken feature.
-Corrected the indentation in coding style issues.

Michal Simek (1):
   i2c: xiic: Fix coding style issues

Raviteja Narayanam (7):
   i2c: xiic: Fix Tx Interrupt path for grouped messages
   i2c: xiic: Add standard mode support for > 255 byte read transfers
   i2c: xiic: Switch to Xiic standard mode for i2c-read
   i2c: xiic: Remove interrupt enable/disable in Rx path
   dt-bindings: i2c: xiic: Add 'xlnx,axi-iic-2.1' to compatible
   i2c: xiic: Update compatible with new IP version
   i2c: xiic: Add smbus_block_read functionality

Shubhrajyoti Datta (2):
   i2c: xiic: Return value of xiic_reinit
   i2c: xiic: Fix the type check for xiic_wakeup

  .../bindings/i2c/xlnx,xps-iic-2.00.a.yaml     |   4 +-
  drivers/i2c/busses/i2c-xiic.c                 | 593 ++++++++++++++----
  2 files changed, 487 insertions(+), 110 deletions(-)

Acked-by: Michal Simek <redacted>

I just tested this patchset on next-20210716 and the XIIC failures are still
present, see:

The probe of ' atmel_mxt_ts' failed as per the error. May I know the details of
your test case if you tweaked any i2ctransfers/added delays. 
If it failed without adding anything, then please check whether the vivado design constraints
are correctly applied or not. 
Also check if the other devices on the bus are detected and i2ctransfer command is successful on them.
It would be helpful to know if the device ' atmel_mxt_ts' is successfully probed with next-20210716
without applying this patchset. 

I have tested this again on our boards with eeprom and other sensors, this is working fine for us.

Regards,
Raviteja N

xiic-i2c a0010000.i2c: mmio a0010000 irq 36 xiic-i2c a0120000.i2c: mmio
a0120000 irq 38 atmel_mxt_ts 3-004a: supply vdda not found, using dummy
regulator atmel_mxt_ts 3-004a: supply vdd not found, using dummy
regulator

xiic-i2c a0120000.i2c: Timeout waiting at Tx empty

atmel_mxt_ts 3-004a: __mxt_read_reg: i2c transfer failed (-5) atmel_mxt_ts
3-004a: mxt_bootloader_read: i2c recv failed (-5) atmel_mxt_ts 3-004a:
Trying alternate bootloader address atmel_mxt_ts 3-004a:
mxt_bootloader_read: i2c recv failed (-5)
atmel_mxt_ts: probe of 3-004a failed with error -5

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel