Re: [PATCH 09/22] clk: mediatek: Add MT8195 imgsys clock support
From: Chen-Yu Tsai <wenst@chromium.org>
Date: 2021-07-06 09:07:25
Also in:
linux-clk, linux-devicetree, linux-mediatek, lkml
Hi, On Thu, Jun 17, 2021 at 7:01 AM Chun-Jie Chen [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Add MT8195 imgsys clock providers Signed-off-by: Chun-Jie Chen <redacted> --- drivers/clk/mediatek/Kconfig | 6 ++ drivers/clk/mediatek/Makefile | 1 + drivers/clk/mediatek/clk-mt8195-img.c | 98 +++++++++++++++++++++++++++ 3 files changed, 105 insertions(+) create mode 100644 drivers/clk/mediatek/clk-mt8195-img.cdiff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig index 6a6e496d08a4..f92d0b6b7eec 100644 --- a/drivers/clk/mediatek/Kconfig +++ b/drivers/clk/mediatek/Kconfig@@ -612,6 +612,12 @@ config COMMON_CLK_MT8195_CCUSYS help This driver supports MediaTek MT8195 ccusys clocks. +config COMMON_CLK_MT8195_IMGSYS + bool "Clock driver for MediaTek MT8195 imgsys" + depends on COMMON_CLK_MT8195 + help + This driver supports MediaTek MT8195 imgsys clocks. + config COMMON_CLK_MT8516 bool "Clock driver for MediaTek MT8516" depends on ARCH_MEDIATEK || COMPILE_TESTdiff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile index bb8aac6f9185..1768eda917c2 100644 --- a/drivers/clk/mediatek/Makefile +++ b/drivers/clk/mediatek/Makefile@@ -85,5 +85,6 @@ obj-$(CONFIG_COMMON_CLK_MT8195_AUDSYS) += clk-mt8195-aud.o obj-$(CONFIG_COMMON_CLK_MT8195_AUDSYS_SRC) += clk-mt8195-aud_src.o obj-$(CONFIG_COMMON_CLK_MT8195_CAMSYS) += clk-mt8195-cam.o obj-$(CONFIG_COMMON_CLK_MT8195_CCUSYS) += clk-mt8195-ccu.o +obj-$(CONFIG_COMMON_CLK_MT8195_IMGSYS) += clk-mt8195-img.o obj-$(CONFIG_COMMON_CLK_MT8516) += clk-mt8516.o obj-$(CONFIG_COMMON_CLK_MT8516_AUDSYS) += clk-mt8516-aud.odiff --git a/drivers/clk/mediatek/clk-mt8195-img.c b/drivers/clk/mediatek/clk-mt8195-img.c new file mode 100644 index 000000000000..923fa82aedae --- /dev/null +++ b/drivers/clk/mediatek/clk-mt8195-img.c@@ -0,0 +1,98 @@ +// SPDX-License-Identifier: GPL-2.0-only +// +// Copyright (c) 2021 MediaTek Inc. +// Author: Chun-Jie Chen <chun-jie.chen@mediatek.com> + +#include <linux/clk-provider.h> +#include <linux/platform_device.h> + +#include "clk-mtk.h" +#include "clk-gate.h" + +#include <dt-bindings/clock/mt8195-clk.h> + +static const struct mtk_gate_regs img_cg_regs = { + .set_ofs = 0x4, + .clr_ofs = 0x8, + .sta_ofs = 0x0, +}; + +#define GATE_IMG(_id, _name, _parent, _shift) \ + GATE_MTK(_id, _name, _parent, &img_cg_regs, _shift, &mtk_clk_gate_ops_setclr) + +static const struct mtk_gate img_clks[] = { + GATE_IMG(CLK_IMG_LARB9, "img_larb9", "img_sel", 0), + GATE_IMG(CLK_IMG_TRAW0, "img_traw0", "img_sel", 1), + GATE_IMG(CLK_IMG_TRAW1, "img_traw1", "img_sel", 2), + GATE_IMG(CLK_IMG_TRAW2, "img_traw2", "img_sel", 3), + GATE_IMG(CLK_IMG_TRAW3, "img_traw3", "img_sel", 4), + GATE_IMG(CLK_IMG_DIP0, "img_dip0", "img_sel", 8), + GATE_IMG(CLK_IMG_WPE0, "img_wpe0", "img_sel", 9), + GATE_IMG(CLK_IMG_IPE, "img_ipe", "img_sel", 10), + GATE_IMG(CLK_IMG_DIP1, "img_dip1", "img_sel", 11), + GATE_IMG(CLK_IMG_WPE1, "img_wpe1", "img_sel", 12), + GATE_IMG(CLK_IMG_GALS, "img_gals", "img_sel", 31), +}; + +static const struct mtk_gate img1_dip_top_clks[] = { + GATE_IMG(CLK_IMG1_DIP_TOP_LARB10, "img1_dip_top_larb10", "img_sel", 0), + GATE_IMG(CLK_IMG1_DIP_TOP_DIP_TOP, "img1_dip_top_dip_top", "img_sel", 1), +}; + +static const struct mtk_gate img1_dip_nr_clks[] = { + GATE_IMG(CLK_IMG1_DIP_NR_RESERVE, "img1_dip_nr_reserve", "img_sel", 0),
Adding a clock for a bit that is named "reserved" is sort of weird. Does it actually exist and function? Otherwise, Reviewed-by: Chen-Yu Tsai <wenst@chromium.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel