Re: [PATCH v4 2/2] kasan: Add memzero int for unaligned size at DEBUG

From
Marco Elver <elver@google.com>
Date
2021-07-02 09:37:46
Also in
linux-mediatek, linux-mm, lkml
Reply to
unknown sender, 2021-07-02
On Fri, Jul 02, 2021 at 04:54PM +0800, yee.lee@mediatek.com wrote:
From: Yee Lee <redacted>

Issue: when SLUB debug is on, hwtag kasan_unpoison() would overwrite
the redzone of object with unaligned size.

An additional memzero_explicit() path is added to replacing init by
hwtag instruction for those unaligned size at SLUB debug mode.

The penalty is acceptable since they are only enabled in debug mode,
not production builds. A block of comment is added for explanation.

---
 v4:
 - Add "slab.h" header
 - Use slub_debug_enabled_unlikely() to replace IS_ENABLED
 - Refine the comment block
^^ this changelog ...
 
---
^^  this '---' is wrong unfortunately.
Signed-off-by: Yee Lee <redacted>
Suggested-by: Marco Elver <elver@google.com>
Suggested-by: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>

... should come after the tags.


git am removes anything between the first '---' and the actual patch
from the commit message.

The typical convention is to place the changelog after a '---' _after_
the tags, so that it is removed from the final commit message.

I think the code looks fine now, so please go ahead and send v5.

Thanks,
-- Marco

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (2 messages) 2 messages, 2 authors, last reply 2021-07-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help