Re: [PATCH v2] pinctrl: mediatek: Fix fallback behavior for bias_set_combo
From: Chen-Yu Tsai <wenst@chromium.org>
Date: 2021-07-01 08:41:16
Also in:
linux-gpio, linux-mediatek, lkml
From: Chen-Yu Tsai <wenst@chromium.org>
Date: 2021-07-01 08:41:16
Also in:
linux-gpio, linux-mediatek, lkml
On Thu, Jul 1, 2021 at 4:10 PM Hsin-Yi Wang [off-list ref] wrote:
Some pin doesn't support PUPD register, if it fails and fallbacks with
bias_set_combo case, it will call mtk_pinconf_bias_set_pupd_r1_r0() to
modify the PUPD pin again.
Since the general bias set are either PU/PD or PULLSEL/PULLEN, try
bias_set or bias_set_rev1 for the other fallback case. If the pin
doesn't support neither PU/PD nor PULLSEL/PULLEN, it will return
-ENOTSUPP.
Fixes: 81bd1579b43e ("pinctrl: mediatek: Fix fallback call path")
Signed-off-by: Hsin-Yi Wang <redacted>Reviewed-by: Chen-Yu Tsai <wenst@chromium.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel