Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES)
From: Mark Rutland <mark.rutland@arm.com>
Date: 2021-06-08 08:58:42
Also in:
dri-devel
On Mon, Jun 07, 2021 at 05:50:57PM +0200, Arnd Bergmann wrote:
On Mon, Jun 7, 2021 at 5:17 PM Maxime Ripard [off-list ref] wrote:quoted
On Mon, Jun 07, 2021 at 03:57:41PM +0200, Arnd Bergmann wrote:quoted
On Mon, Jun 7, 2021 at 3:39 PM Will Deacon [off-list ref] wrote:quoted
On Mon, Jun 07, 2021 at 02:08:59PM +0100, Mark Rutland wrote:quoted
On Mon, Jun 07, 2021 at 01:01:18PM +0100, Mark Rutland wrote:quoted
On Mon, Jun 07, 2021 at 11:58:32AM +0200, Marek Szyprowski wrote:I notice that it checks index 'fifos_state[channel].in_use', but then uses a different index 'i' for looking at the 'pending_commit' field beyond the end of the array. This code was introduced by Maxime Ripard in commit 9ec03d7f1ed3 ("drm/vc4: kms: Wait on previous FIFO users before a commit").Awesome, I tried to find out that bug a few weeks ago but couldn't reproduce the KASAN spat. You're right, it should be channel here instead of i. Since you did the whole work, do you want to send the patch?Marek and Mark did most of the work finding the problem, I just looked in the right place a few times (and a bit in the wrong place). I'd suggest you send that patch with the corresponding Reported-by/Analyzed-by/ Tested-by tags.
I've sent: https://lore.kernel.org/r/20210608085513.2069-1-mark.rutland@arm.com (local) Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel