Re: [PATCH] drm/stm: ltdc: improve pm_runtime to stop clocks
From: Marek Vasut <marex@denx.de>
Date: 2021-06-30 00:35:11
Also in:
dri-devel, lkml
On 6/29/21 1:58 PM, Raphael GALLAIS-POU - foss wrote: [...]
quoted hunk ↗ jump to hunk
+++ b/drivers/gpu/drm/stm/ltdc.c@@ -425,10 +425,17 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc, { struct ltdc_device *ldev = crtc_to_ltdc(crtc); struct drm_device *ddev = crtc->dev; + int ret; DRM_DEBUG_DRIVER("\n"); - pm_runtime_get_sync(ddev->dev); + if (!pm_runtime_active(ddev->dev)) { + ret = pm_runtime_get_sync(ddev->dev);
All these if (!pm_runtime_active()) then pm_runtime_get_sync() calls look like workaround for some larger issue. Shouldn't the pm_runtime do some refcounting on its own , so this shouldn't be needed ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel