Re: [PATCH] arm64: dts: armada-3720-turris-mox.dts: remove mrvl,i2c-fast-mode
From: Marek Behún <kabel@kernel.org>
Date: 2021-06-28 13:06:03
Also in:
linux-devicetree, lkml
On Mon, 28 Jun 2021 14:10:15 +0200 Pali Rohár [off-list ref] wrote:
+ /delete-property/mrvl,i2c-fast-mode;
Can you add an additional space here? /delete-property/ mrvl,i2c-fast-mode; Other than that Reviewed-by: Marek Behún <kabel@kernel.org> BTW the i2c driver should me made to respect the `clock-frequency` DT property, not the fast-mode nonsense. The `mrvl,i2c-fast-mode` should be IMO completely removed and whether it is enabled should be decided by the value of `clock-frequency`. BTW there are clock generating registers in A3720 I2C controller that can generate 100 kHz even in fast-mode. The driver does not use them, though, it leaves them to their default values, which for normal mode generate ~96 kHz and for fast mode ~258 kHz. Maybe we should implement configuring these registers and make the driver choose normal-mode / fast-mode / high-speed mode depending on `clock-frequency` ? Marek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel