Thread (12 messages) 12 messages, 7 authors, 2021-06-28

Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

From: Linus Walleij <hidden>
Date: 2021-06-28 11:10:40
Also in: dri-devel, linux-arm-msm, linux-mediatek, linux-samsung-soc, lkml

On Wed, Mar 3, 2021 at 11:31 AM Nicolas Boichat [off-list ref] wrote:
On Mon, Mar 1, 2021 at 4:59 PM Linus Walleij [off-list ref] wrote:
quoted
quoted
                dsi->mode_flags =
                        MIPI_DSI_CLOCK_NON_CONTINUOUS |
-                       MIPI_DSI_MODE_EOT_PACKET;
+                       MIPI_DSI_MODE_NO_EOT_PACKET;
Same, just delete the flag.

These are all just semantic bugs due to the ambiguity of the flags, it is
possible to provide a Fixes: flag for each file using this flag the wrong way
but I dunno if it's worth it.
Wow nice catch.

I think we should fix all of those _before_ my patch is applied, with
proper Fixes tags so that this can be backported to stable branches,
even if it's a no-op. I can look into it but that may take a bit of
time.
This is fixed now, please will you proceed with this patch, because I
really like it!

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help