RE: [PATCH] drivers/perf: fix the missed ida_simple_remove() in ddr_perf_probe()
From: Aisheng Dong <aisheng.dong@nxp.com>
Date: 2021-06-17 12:24:19
Also in:
lkml
From: Jing Xiangfeng <redacted> Sent: Thursday, June 17, 2021 8:26 PM Subject: [PATCH] drivers/perf: fix the missed ida_simple_remove() in ddr_perf_probe()
drivers/perf: imx8_ddr: xxxx Otherwise: Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> Regards Aisheng
quoted hunk ↗ jump to hunk
ddr_perf_probe() misses to call ida_simple_remove() in an error path. Jump to cpuhp_state_err to fix it. Signed-off-by: Jing Xiangfeng <redacted> --- drivers/perf/fsl_imx8_ddr_perf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c index 2bbb93188064..7b87aaf267d5 100644 --- a/drivers/perf/fsl_imx8_ddr_perf.c +++ b/drivers/perf/fsl_imx8_ddr_perf.c@@ -705,8 +705,10 @@ static int ddr_perf_probe(struct platform_device*pdev) name = devm_kasprintf(&pdev->dev, GFP_KERNEL, DDR_PERF_DEV_NAME "%d", num); - if (!name) - return -ENOMEM; + if (!name) { + ret = -ENOMEM; + goto cpuhp_state_err; + } pmu->devtype_data = of_device_get_match_data(&pdev->dev); -- 2.26.0.106.g9fadedd
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel