On Thu, Jun 17, 2021 at 03:42:43PM +0800, 班涛 wrote:

Mark Brown [off-list ref] 于2021年6月15日周二 下午9:22写道：

quoted

quoted

@@ -0,0 +1,408 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * ALSA SoC DMIC Audio Layer
+ *
+ * Copyright 2021 Ban Tao <fengzheng923@gmail.com>
+ *

quoted

Please make the entire comment a C++ one so things look more
intentional.

For example;
// SPDX-License-Identifier: GPL-2.0-or-later
/*
 * This driver supports the DMIC in Allwinner's H6 SoCs.
 *
 * Copyright 2021 Ban Tao [off-list ref]
 *
 */
is this OK?

No, that's what you have already make the entire thing a C++ comment
with //s.

quoted

quoted

+     res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+     base = devm_ioremap_resource(&pdev->dev, res);

devm_platform_ioremap_resource()

But I need to get the register base address of DMIC. E.g res->start.
host->dma_params_rx.addr = res->start + SUN50I_DMIC_DATA;

OK.