Re: [PATCH -next] drivers: usb: add missing MODULE_DEVICE_TABLE definition in brcmstb-usb-pinmap.c
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-06-16 06:17:58
Also in:
linux-usb, lkml
On Tue, Jun 15, 2021 at 07:50:03PM -0800, Yu Jiahua wrote:
quoted hunk ↗ jump to hunk
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module. Signed-off-by: Yu Jiahua <redacted> --- drivers/usb/misc/brcmstb-usb-pinmap.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/usb/misc/brcmstb-usb-pinmap.c b/drivers/usb/misc/brcmstb-usb-pinmap.c index b3cfe8666ea7..cbc958355359 100644 --- a/drivers/usb/misc/brcmstb-usb-pinmap.c +++ b/drivers/usb/misc/brcmstb-usb-pinmap.c@@ -331,6 +331,7 @@ static const struct of_device_id brcmstb_usb_pinmap_of_match[] = { { .compatible = "brcm,usb-pinmap" }, { }, }; +MODULE_DEVICE_TABLE(of, brcmstb_usb_pinmap_of_match);
I have asked you all to stop sending these types of patches until you can prove that they are actually needed. Is this change really needed? Does the presence of a of table determine if this module should be loaded or not? How did you find this problem? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel