Thread (22 messages) 22 messages, 7 authors, 2021-06-15

Re: Arm64 crash while reading memory sysfs

From: Mike Rapoport <hidden>
Date: 2021-06-15 06:06:08
Also in: linux-mm, lkml

On Mon, Jun 14, 2021 at 05:13:51PM -0700, Andrew Morton wrote:
On Mon, 14 Jun 2021 11:25:54 +0300 Mike Rapoport [off-list ref] wrote:
quoted
On Tue, Jun 08, 2021 at 12:36:21PM +0530, Anshuman Khandual wrote:
quoted

On 5/28/21 10:43 AM, Mike Rapoport wrote:
quoted
On Thu, May 27, 2021 at 03:56:44PM -0700, Andrew Morton wrote:
quoted
On Thu, 27 May 2021 18:50:48 +0100 Catalin Marinas [off-list ref] wrote:
quoted
quoted
Can you please try Anshuman's patch "arm64/mm: Drop HAVE_ARCH_PFN_VALID":

https://lore.kernel.org/lkml/1621947349-25421-1-git-send-email-anshuman.khandual@arm.com (local)

It seems to me that the check for memblock_is_memory() in
arm64::pfn_valid() is what makes init_unavailable_range() to bail out for
section parts that are not actually populated and then we have
VM_BUG_ON_PAGE(PagePoisoned(p)) for these pages.
I acked Anshuman's patch, I think they all need to go in together.
That's neat.   Specifically which patches are we referring to here?
arm64: drop pfn_valid_within() and simplify pfn_valid():
https://lore.kernel.org/lkml/20210511100550.28178-5-rppt@kernel.org (local)

arm64/mm: Drop HAVE_ARCH_PFN_VALID:
https://lore.kernel.org/lkml/1621947349-25421-1-git-send-email-anshuman.khandual@arm.com (local)
I dont see the above patch (which drops HAVE_ARCH_PFN_VALID on arm64) on linux-next
i.e. next-20210607. I might have missed some earlier context here but do not we want
to fallback on generic pfn_valid() after Mike's series ?
Andrew,

Can you please pick the two patches above?
I already had

include-linux-mmzoneh-add-documentation-for-pfn_valid.patch
memblock-update-initialization-of-reserved-pages.patch
arm64-decouple-check-whether-pfn-is-in-linear-map-from-pfn_valid.patch
arm64-drop-pfn_valid_within-and-simplify-pfn_valid.patch

and I just added

arm64-mm-drop-have_arch_pfn_valid.patch

so I think we're all good now?
Yes. 
 
and I don't think any of this is needed in 5.13 or -stable, correct?
Right.
 
I still have question marks over

https://lkml.kernel.org/r/YJ0Fhs5krPJ0FgiV@kernel.org and
https://lkml.kernel.org/r/d55f915c-ad01-e729-1e29-b57d78257cbb@quicinc.com

Is this all OK now?
Yes, it is.

-- 
Sincerely yours,
Mike.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help