Re: [PATCH v3 1/4] remoteproc: core: Move cdev add before device add
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-06-15 04:56:20
Also in:
linux-arm-msm, linux-remoteproc, lkml, stable
On Mon, Jun 14, 2021 at 07:21:08PM -0700, Siddharth Gupta wrote:
When cdev_add is called after device_add has been called there is no way for the userspace to know about the addition of a cdev as cdev_add itself doesn't trigger a uevent notification, or for the kernel to know about the change to devt. This results in two problems: - mknod is never called for the cdev and hence no cdev appears on devtmpfs. - sysfs links to the new cdev are not established. The cdev needs to be added and devt assigned before device_add() is called in order for the relevant sysfs and devtmpfs entries to be created and the uevent to be properly populated.
So this means no one ever ran this code on a system that used devtmpfs? How was it ever tested? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel