Thread (8 messages) 8 messages, 3 authors, 2021-06-12

Re: [PATCH v3 2/3] dt-bindings: iommu: add DART iommu bindings

From: Sven Peter <hidden>
Date: 2021-06-12 12:25:36
Also in: linux-devicetree, linux-iommu, lkml

Hi,

On Thu, Jun 10, 2021, at 18:52, Rob Herring wrote:
On Thu, Jun 03, 2021 at 10:50:02AM +0200, Sven Peter wrote:
quoted
+
+examples:
+  - |+
+    dart1: iommu@82f80000 {
+      compatible = "apple,t8103-dart";
+      reg = <0x82f80000 0x4000>;
+      interrupts = <1 781 4>;
+      #iommu-cells = <1>;
+    };
+
+    master1 {
+      iommus = <&{/dart1} 0>;
/dart1 is a path, but 'dart1' is a label. You need '&dart1' (or 
'&{/iommu@82f80000}' but that doesn't really work here because the 
examples get prefixed with /example-n/...)

With that fixed,

Reviewed-by: Rob Herring <robh@kernel.org>
Makes sense, thanks for the review!
Fixed for the next version.


Sven

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help