Re: [PATCH v11 14/33] counter: interrupt-cnt: Add const qualifier for actions_list array

On Wed, Jun 09, 2021 at 04:29:42PM +0100, Jonathan Cameron wrote:

On Wed,  9 Jun 2021 10:31:17 +0900
William Breathitt Gray [off-list ref] wrote:

quoted

The struct counter_synapse actions_list member expects a const enum
counter_synapse_action array. This patch adds the const qualifier to the
interrupt_cnt_synapse_actionss to match actions_list.

Cc: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: William Breathitt Gray <redacted>

Naming looks unusual...

quoted

---
 drivers/counter/interrupt-cnt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/counter/interrupt-cnt.c b/drivers/counter/interrupt-cnt.c
index 827d785e19b4..0e07607f2cd3 100644
--- a/drivers/counter/interrupt-cnt.c
+++ b/drivers/counter/interrupt-cnt.c

@@ -77,7 +77,7 @@ static const struct counter_count_ext interrupt_cnt_ext[] = {
 	},
 };
 
-static enum counter_synapse_action interrupt_cnt_synapse_actionss[] = {
+static const enum counter_synapse_action interrupt_cnt_synapse_actionss[] = {

actions?

Perhaps good to fix that whilst we are here.

quoted

 	COUNTER_SYNAPSE_ACTION_RISING_EDGE,
 };
 

Hi Oleksij,

Would you take a look at this driver and let us know whether the two 's'
at the end of this symbol is intentional?

Thanks,

William Breathitt Gray