Re: [PATCH v2 0/4] fpga: reorganize to subdirs
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-06-09 14:53:39
Also in:
linux-fpga, lkml
On Wed, Jun 09, 2021 at 07:22:03AM -0700, trix@redhat.com wrote:
From: Tom Rix <trix@redhat.com> The incoming xrt patchset has a toplevel subdir xrt/ The current fpga/ uses a single dir with filename prefixes to subdivide owners For consistency, there should be only one way to organize the fpga/ dir. Because the subdir model scales better, refactor to use it. The discussion wrt xrt is here: https://lore.kernel.org/linux-fpga/68e85a4f-4a10-1ff9-0443-aa565878c855@redhat.com/ (local) Follow drivers/net/ethernet/ which has control configs NET_VENDOR_BLA that map to drivers/net/ethernet/bla Since fpgas do not have many vendors, drop the 'VENDOR' and use FPGA_BLA. There are several new subdirs altera/ dfl/ lattice/ xilinx/ Each subdir has a Kconfig that has a new/reused if FPGA_BLA ... existing configs ... endif FPGA_BLA Which is sourced into the main fpga/Kconfig Each subdir has a Makefile whose transversal is controlled in the fpga/Makefile by obj-$(CONFIG_FPGA_BLA) += bla/ Some cleanup to arrange thing alphabetically and make fpga/Makefile's whitespace look more like net/'s Changes from v1 Drop renaming files Cleanup makefiles
You can rename the files, you just can not rename the .ko objects without everyone knowing what you are doing and you trying to bury it in the middle of a differently described patch. If you want to do that, do you? I don't really understand why you want to move things around right now other than "we have 40 files in one directory, ick!". greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel