Re: [PATCH] dmaengine: xilinx: dpdma: fix kernel-doc
From: Nick Desaulniers <ndesaulniers@google.com>
Date: 2021-06-08 18:53:42
Also in:
dmaengine, lkml
On Tue, Jun 8, 2021 at 2:38 AM Yang Li [off-list ref] wrote:
Fix function name in xilinx/xilinx_dpdma.c kernel-doc comment to remove a warning found by clang(make W=1 LLVM=1). drivers/dma/xilinx/xilinx_dpdma.c:935: warning: expecting prototype for xilinx_dpdma_chan_no_ostand(). Prototype was for xilinx_dpdma_chan_notify_no_ostand() instead.
xilinx_dpdma_chan_notify_no_ostand has static linkage, clang shouldn't be emitting such a warning for this function. Which tree was Abaci run on? Do you have the original report? This warning doesn't look right to me. Again, the diff seems fine, but the commit message does not.
quoted hunk ↗ jump to hunk
Reported-by: Abaci Robot <redacted> Signed-off-by: Yang Li <redacted> --- drivers/dma/xilinx/xilinx_dpdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c index 70b29bd..0c8739a 100644 --- a/drivers/dma/xilinx/xilinx_dpdma.c +++ b/drivers/dma/xilinx/xilinx_dpdma.c@@ -915,7 +915,7 @@ static u32 xilinx_dpdma_chan_ostand(struct xilinx_dpdma_chan *chan) } /** - * xilinx_dpdma_chan_no_ostand - Notify no outstanding transaction event + * xilinx_dpdma_chan_notify_no_ostand - Notify no outstanding transaction event * @chan: DPDMA channel * * Notify waiters for no outstanding event, so waiters can stop the channel --1.8.3.1
-- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel