On 07/06/2021 07:20, Chun-Jie Chen wrote:

On Wed, 2021-06-02 at 12:12 -0500, Rob Herring wrote:

quoted

On Mon, May 24, 2021 at 08:20:32PM +0800, Chun-Jie Chen wrote:

quoted

This patch adds the new binding documentation of imp i2c wrapper
controller
for Mediatek MT8192.

Signed-off-by: Weiyi Lu <redacted>
Signed-off-by: chun-jie.chen <redacted>
---
 .../arm/mediatek/mediatek,imp_iic_wrap.yaml   | 80
+++++++++++++++++++
 1 file changed, 80 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/arm/mediatek/mediatek,imp_iic_wra
p.yaml

diff --git
a/Documentation/devicetree/bindings/arm/mediatek/mediatek,imp_iic_w
rap.yaml
b/Documentation/devicetree/bindings/arm/mediatek/mediatek,imp_iic_w
rap.yaml
new file mode 100644
index 000000000000..fb6cb9e60ee2

--- /dev/null
+++

b/Documentation/devicetree/bindings/arm/mediatek/mediatek,imp_iic_w
rap.yaml

@@ -0,0 +1,80 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: 

http://devicetree.org/schemas/arm/mediatek/mediatek,imp_iic_wrap.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek IMP I2C Wrapper Controller
+
+maintainers:
+  - Chun-Jie Chen [off-list ref]
+
+description:
+  The Mediatek imp i2c wrapper controller provides functional
configurations and clocks to the system.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - mediatek,mt8192-imp_iic_wrap_c
+          - mediatek,mt8192-imp_iic_wrap_e
+          - mediatek,mt8192-imp_iic_wrap_s
+          - mediatek,mt8192-imp_iic_wrap_ws
+          - mediatek,mt8192-imp_iic_wrap_w
+          - mediatek,mt8192-imp_iic_wrap_n

Looks to me like these are all the same h/w, but just have differing 
sets of clocks. That's not really a reason to have different 
compatibles. 

If you need to know what clocks are present, you can walk the DT for 
all 'clocks' properties matching this clock controller instance. Or
use 
'clock-indices' to define which ones are present.

Rob

Some module is divided to sub-modules which are designed in different
h/w blocks for different usage, and if we want to use the same
compatible to present these h/w blocks, we need to move the clock data
provided by these h/w blocks to dts, but we usually use different
compatible to get the h/w blocks data in
Mediatek's clock driver, so do you suggest to register clock provided
by different h/w blocks using same compatible?

The mapping of them is as following:
imp_iic_wrap_c:  11007000
imp_iic_wrap_e:  11cb1000
imp_iic_wrap_s:  11d03000
imp_iic_wrap_ws: 11d23000
imp_iic_wrap_w:  11e01000
imp_iic_wrap_n:  11f02000

Regards,
Matthias

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel