Re: [PATCH] drm/mediatek: remove redundant error log print
From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date: 2021-06-08 00:18:43
Also in:
dri-devel, linux-mediatek, lkml
Hi, Bernard: Bernard Zhao [off-list ref] 於 2021年6月3日 週四 下午7:15寫道：
quoted hunk ↗ jump to hunk
Fix coccicheck warning: drivers/gpu/drm/mediatek/mtk_dsi.c:1074:2-9: line 1074 is redundant because platform_get_irq() already prints an error. Signed-off-by: Bernard Zhao <redacted> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index ae403c67cbd9..e2e4fc8b1360 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c@@ -1082,10 +1082,8 @@ static int mtk_dsi_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq, IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi);
devm_request_irq() would have below call stack to allocate memory. When allocate memory fail, it would not print any error message, doesn't it? devm_request_irq() -> devm_request_threaded_irq() -> devres_alloc() -> devres_alloc_node() -> alloc_dr() -> kmalloc_node_track_caller() Regards, Chun-Kuang.
- if (ret) {
- dev_err(&pdev->dev, "failed to request mediatek dsi irq\n");
+ if (ret)
goto err_unregister_host;
- }
init_waitqueue_head(&dsi->irq_wait_queue);
--
2.31.0_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel