Re: [PATCH 1/3] net: stmmac: explicitly deassert GMAC_AHB_RESET
From: Matthew Hagan <hidden>
Date: 2021-06-06 14:40:05
Also in:
linux-arm-msm, linux-devicetree, lkml, netdev
On 06/06/2021 04:24, Bjorn Andersson wrote:
quoted
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index 97a1fedcc9ac..d8ae58bdbbe3 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c@@ -600,6 +600,13 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) goto error_hw_init; } + plat->stmmac_ahb_rst = devm_reset_control_get_optional_shared( + &pdev->dev, "ahb"); + if (IS_ERR(plat->stmmac_ahb_rst)) { + ret = plat->stmmac_ahb_rst;You need a PTR_ERR() around the plat->stmmac_ahb_rst.
This is giving a warning. Shouldn't v1 be kept as it is here? Please refer to "net: stmmac: platform: use optional clk/reset get APIs" [1] which modified error handling for plat->stmmac_rst. PTR_ERR() would then be called by the parent function on the returned value of ret. [1]: https://lore.kernel.org/netdev/20201112092606.5173aa6f@xhacker.debian/ (local) Thanks, Matthew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel